Revert state changes if precompile execution fails

ethereum · Aug 28, 2017 · cedfc93 · cedfc93
1 parent f82d16a
commit cedfc93
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ethereumj-core/src/main/java/org/ethereum/vm/program/Program.java b/ethereumj-core/src/main/java/org/ethereum/vm/program/Program.java
@@ -1176,15 +1176,15 @@ public void callToPrecompiledAddress(MessageCall msg, PrecompiledContract contra
             if (out.getLeft()) { // success
                 this.refundGas(msg.getGas().longValue() - requiredGas, "call pre-compiled");
                 this.stackPushOne();
+                track.commit();
             } else {
-                // spend all gas on failure and push zero
+                // spend all gas on failure, push zero and revert state changes
                 this.refundGas(0, "call pre-compiled");
                 this.stackPushZero();
+                track.rollback();
             }
 
             this.memorySave(msg.getOutDataOffs().intValue(), out.getRight());
-
-            track.commit();
         }
     }