[ShadCN]: Migrate CreateAccount Screen #14808
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
54fd7a7 to
34b2322
Compare
| > | ||
| <Spinner w={SPINNER_SIZE} h={SPINNER_SIZE} /> | ||
| <Spinner className={SPINNER_SIZE} /> |
There was a problem hiding this comment.
not a blocker but we could set this size directly in the Spinner component as it default value/size
There was a problem hiding this comment.
Ok! Would need to check the other related instances this component is being used, because there is only one other place where this size is explicitly applied.
So, make a note to check it in a separate PR?
| "shadow-[0_0_7px_0_var(--eth-colors-blackAlpha-800)]", | ||
| "shadow-[0_0_7px_0_var(--eth-colors-whiteAlpha-800)]" |
There was a problem hiding this comment.
lets simplify this by using shadow-md
| `} | ||
| transitionDelay={numToMsString(getDelayFromIndex(index))} | ||
| position="relative" | ||
| className={`[--display-delay:${numToMsString(getDelayFromIndex(index))}] delay-(--display-delay)`} |
| overflow="hidden" | ||
| w="full" | ||
| > | ||
| <div className="h-90 grid w-full grid-cols-4 gap-2 overflow-hidden whitespace-nowrap md:h-[152px]"> |
There was a problem hiding this comment.
| <div className="h-90 grid w-full grid-cols-4 gap-2 overflow-hidden whitespace-nowrap md:h-[152px]"> | |
| <div className="h-[90px] grid w-full grid-cols-4 gap-2 overflow-hidden whitespace-nowrap md:h-[152px]"> |
|
@pettinarip updated the stories to be better presentable, but running into that same Chromatic error that is present in the Once we can address this, I can then push that overflow fix so I can verify the change in Chromatic. |
|
@TylerAPfledderer there was a missing image that was breaking the dev branch fixed in #14837. Please update your branch |
|
@pettinarip updated! |
Description
Create stories and migrate components for the
CreateAccountsimulator screen to Tailwind/ShadCN