Remove incorrect usage of additionalProperties #502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
additionalProperties: false
here is incorrect as each sub schema is evaluated independently, so what ends up happening is that when the second schema is evaluated which only hastransactions_root
as property, it will complain that there are additional properties if we pass aExecutionPayloadHeader
value since it has more properties likeparent_hash
.This is the error when running spec tests in Lodestar
And the more detailed error
It also seems like we only use
additionalProperties: false
in the bellatrix types.eg. capella types don't use it
beacon-APIs/types/capella/execution_payload.yaml
Lines 49 to 53 in 5815ac5