Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Upgrade EVMC to version 7.0.0 #5810

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Upgrade EVMC to version 7.0.0 #5810

merged 2 commits into from
Nov 12, 2019

Conversation

chfast
Copy link
Member

@chfast chfast commented Nov 6, 2019

Questions:

  • Is aleth-interpreter still being tested?
  • Are we running any CHAINID tests?

@chfast chfast requested review from gumb0 and halfalicious November 6, 2019 21:55
@gumb0
Copy link
Member

gumb0 commented Nov 7, 2019

Is aleth-interpreter still being tested?

Yes, but here it fails to load

#!/bin/bash -eo pipefail
ETHEREUM_TEST_PATH=~/project/test/jsontests \
test/testeth -t GeneralStateTests -- --vm libaleth-interpreter/libaleth-interpreter.so
terminate called after throwing an instance of 'boost::wrapexcept<std::system_error>'
  what():  loading lib*****-interpreter/lib*****-interpreter.so failed: EVMC create function not found: Illegal seek
Received 'aborted' signal

Are we running any CHAINID tests?

Yes, there're GeneralStateTests/stChainId and BCGeneralStateTests/stChainId
Also a couple of unit tests.

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #5810 into release/1.7 will decrease coverage by <.01%.
The diff coverage is 51.51%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.7    #5810      +/-   ##
===============================================
- Coverage        63.83%   63.83%   -0.01%     
===============================================
  Files              358      358              
  Lines            30602    30596       -6     
  Branches          3406     3406              
===============================================
- Hits             19536    19531       -5     
+ Misses            9837     9836       -1     
  Partials          1229     1229

@chfast
Copy link
Member Author

chfast commented Nov 8, 2019

Yes, but here it fails to load

This is related to the change: ethereum/evmc#440

gumb0
gumb0 previously approved these changes Nov 8, 2019
@chfast chfast marked this pull request as ready for review November 12, 2019 12:02
@chfast chfast merged commit db5bd0b into release/1.7 Nov 12, 2019
@chfast chfast deleted the evmc7 branch November 12, 2019 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants