Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

More unit tests for BALANCE and SELFBALANCE #5730

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 2, 2019

Added a couple of tests suggested in #5700 (comment)

And another one checking BALANCE cost in Istanul
@codecov-io
Copy link

Codecov Report

Merging #5730 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5730      +/-   ##
==========================================
+ Coverage   63.32%   63.35%   +0.03%     
==========================================
  Files         353      353              
  Lines       30336    30339       +3     
  Branches     3394     3394              
==========================================
+ Hits        19209    19221      +12     
+ Misses       9894     9881      -13     
- Partials     1233     1237       +4

@gumb0 gumb0 requested review from chfast and halfalicious September 2, 2019 15:26
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if these efforts should rather go to state tests.

@gumb0 gumb0 merged commit 8d31fd3 into master Sep 3, 2019
@gumb0 gumb0 deleted the eip-1884-interpreter branch September 3, 2019 12:35
@gumb0 gumb0 mentioned this pull request Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants