Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Fix enode-address logged at program start when public IP is not known #5609

Merged
merged 3 commits into from
May 22, 2019

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented May 21, 2019

Fix #5415

@gumb0 gumb0 changed the title Log localhost and listen port instead of zeros when public is not known Fix enode-address logged at program start when public IP is not known May 21, 2019
@gumb0 gumb0 removed the in progress label May 21, 2019
@gumb0 gumb0 requested review from chfast and halfalicious May 21, 2019 17:31
@codecov-io
Copy link

Codecov Report

Merging #5609 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5609      +/-   ##
==========================================
- Coverage   62.25%   62.19%   -0.06%     
==========================================
  Files         347      347              
  Lines       29311    29321      +10     
  Branches     3312     3314       +2     
==========================================
- Hits        18247    18236      -11     
- Misses       9874     9888      +14     
- Partials     1190     1197       +7

Copy link
Contributor

@halfalicious halfalicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@gumb0 gumb0 merged commit f4c9854 into master May 22, 2019
@gumb0 gumb0 deleted the log-enode branch May 22, 2019 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aleth / aleth-bootnode log wrong IP address port
4 participants