Remove VMTRACE option

[chfast]

Fixes #5565.

This removes CMake's VMTRACE options by making --vmtrace always available to testeth. Win-Win.

[winsvega]

Wait the option is still used in debug mode. I use it to trace step by step execution.

[codecov-io]

Codecov Report

Merging #5570 into master will decrease coverage by 0.05%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master    #5570      +/-   ##
==========================================
- Coverage   62.64%   62.59%   -0.06%     
==========================================
  Files         350      350              
  Lines       29684    29690       +6     
  Branches     3344     3344              
==========================================
- Hits        18597    18583      -14     
- Misses       9878     9897      +19     
- Partials     1209     1210       +1

[chfast]

Wait the option is still used in debug mode. I use it to trace step by step execution.

Ok then. We will add --vmtrace option also for aleth.

Anyway, can we merge it now and include in 1.6.0 release to make testeth there more useful? If too big or cannot land without the mentioned flag for aleth, I will do it for 1.7.

[gumb0]

I would prefer not to break vmtrace in aleth in 1.6.0

[winsvega]

This removes CMake's VMTRACE options by making --vmtrace always available to testeth. Win-Win.

works

[chfast]

@winsvega Can you elaborate what "works"?
I though you need also tracing logs from running aleth, e.g. aleth --dev. Is that the case?

[winsvega]

From retesteth. Evm debug from the client I propose for the future when retesteth gonna be adapted.

I think @cdetrio Casey was using the trace from clients to check consensus also

[winsvega]

*testeth works with this change

[gumb0]

vmtrace in aleth is useful to debug issues with soltest, and also in case we have a consensus issue during sync.

[chfast]

I don't have time to continue working on this currently, but it would be huge UX improvement to remove compile time flag.

[gumb0]

I will try to finish this.

Not sure if we need additional --vmtrace flag for aleth, I think without it -v 4 --log-channels vmtrace will also work just fine.

[gumb0]

I've added --log-vmtrace flag to aleth, it now controls the global flag for vmtrace, which is in all respects similar to the old compile-time flag. New flag lives in Log.cpp.

This should be ready, please review @chfast @winsvega

[chfast]

Rebased. I will merge it after CI builds.