standard trace fixes #4586
standard trace fixes #4586
Conversation
There was a problem hiding this comment.
@cdetrio @chfast I don't see anything here that could break the interpreter, and it does appear to put all the logging hooks at the start of each operation. Why they weren't in the first place I don't know - I left them as I found them.
So I look forward to passing only a portion of the stack. And to finding a way to fix this problem:
libevm/VM.cpp
Outdated
| @@ -233,13 +233,17 @@ void VM::interpretCases() | |||
| CASE(CREATE2) | |||
| { | |||
| if (!m_schedule->haveCreate2) | |||
| { | |||
| ON_OP(); | |||
There was a problem hiding this comment.
on second thought, shouldn't this go before if (!m_schedule->haveCreate2)?
c491cf2 to
ee64227
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4586 +/- ##
===========================================
- Coverage 58.59% 53.54% -5.06%
===========================================
Files 1091 1618 +527
Lines 55790 70543 +14753
Branches 3604 7224 +3620
===========================================
+ Hits 32691 37771 +5080
- Misses 22046 31528 +9482
- Partials 1053 1244 +191
Continue to review full report at Codecov.
|
|
pushed an edit, should be ready now. |
Some fixes for standardized tracing ethereum/tests#249. See also #4320