Only set database paths if disk db is being used

ethereum · Nov 27, 2019 · 193c839 · 193c839
1 parent b632e12
commit 193c839
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/libethereum/BlockChain.cpp b/libethereum/BlockChain.cpp
@@ -198,9 +198,9 @@ bool BlockChain::open(fs::path const& _path, WithExisting _we)
     unsigned lastMinor = c_databaseMinorVersion;
     bool rebuildNeeded = false;
 
-    db_paths::setDatabasePaths(_path, m_genesisHash);
     if (db::isDiskDatabase())
     {
+        db_paths::setDatabasePaths(_path, m_genesisHash);
         if (_we == WithExisting::Kill)
         {
             LOG(m_loggerInfo)
@@ -234,6 +234,7 @@ bool BlockChain::open(fs::path const& _path, WithExisting _we)
         }
         else
         {
+            // First launch with new database
             LOG(m_loggerDetail) << "Creating database minor version file: "
                                 << db_paths::extrasDatabaseMinorVersionPath()
                                 << " (minor version: " << c_databaseMinorVersion << ")";
@@ -302,7 +303,7 @@ bool BlockChain::open(fs::path const& _path, WithExisting _we)
     // database because the extras database format may have changed
     m_lastBlockNumber = info(m_lastBlockHash).number();
 
-    LOG(m_loggerInfo) << "Opened blockchain database. Latest: " << currentHash()
+    LOG(m_loggerInfo) << "Opened blockchain database. Latest block hash: " << currentHash()
                       << (!rebuildNeeded ? "(rebuild not needed)" : "*** REBUILD NEEDED ***");
     return rebuildNeeded;
 }

diff --git a/libethereum/DatabasePaths.cpp b/libethereum/DatabasePaths.cpp
@@ -30,11 +30,8 @@ bool databasePathsSet()
 
 void setDatabasePaths(fs::path const& _rootPath, h256 const& _genesisHash)
 {
-    if (_genesisHash == h256{})
-    {
-        BOOST_THROW_EXCEPTION(InvalidHash());
-    }
-
+    // Allow empty hashes since they are required by tests
+
     g_rootPath = _rootPath.empty() ? db::databasePath() : _rootPath;
     g_chainPath = g_rootPath / fs::path(toHex(_genesisHash.ref().cropped(0, 4)));
     g_stateDbPath = g_chainPath / fs::path("state");

diff --git a/libethereum/State.cpp b/libethereum/State.cpp
@@ -44,12 +44,15 @@ State::State(State const& _s):
 
 OverlayDB State::openDB(fs::path const& _basePath, h256 const& _genesisHash, WithExisting _we)
 {
-    db_paths::setDatabasePaths(_basePath);
-    if (db::isDiskDatabase() && _we == WithExisting::Kill)
+    if (db::isDiskDatabase())
     {
-        clog(VerbosityInfo, "statedb")
-            << "Deleting state database: " << db_paths::stateDatabasePath();
-        fs::remove_all(db_paths::stateDatabasePath());
+        db_paths::setDatabasePaths(_basePath, _genesisHash);
+        if (_we == WithExisting::Kill)
+        {
+            clog(VerbosityInfo, "statedb")
+                << "Deleting state database: " << db_paths::stateDatabasePath();
+            fs::remove_all(db_paths::stateDatabasePath());
+        }
     }
 
     try