Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-7573: added keyEncryptedSeller to ILockingContract TransferConfirmed event #879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Julius278
Copy link

@Julius278 Julius278 commented Jan 31, 2025

added the already existing keyEncryptedSeller param to the ILockingContract TransferConfirmed event.

/**
* @dev Emitted when the transfer for the token is incepted
* @param id the trade identifier of the trade.
* @param amount the number of tokens to be transferred.
* @param from The address of the seller.
* @param to The address of the buyer.
* @param keyEncryptedSeller Encryption of the key that can be used by the seller to reclaim the token in case of cancellation or failed payment.
* @param keyEncryptedBuyer Encryption of the key that can be used by the buyer to claim the token in case of a successful payment.
*/
event TransferConfirmed(bytes32 id, int amount, address from, address to, string keyEncryptedSeller, string keyEncryptedBuyer);`

In this case its easier to call transferAndDecrypt (buyer) or cancelAndDecrypt (seller) without further interaction with the ILockingContract

@Julius278
Copy link
Author

@cfries
Hi Christian, could you please check that Pull Request?
I guess I dont have the correct access rights or something like that for the automated checks to be successful.
Best regards,
Julius

@cfries
Copy link
Contributor

cfries commented Feb 1, 2025

I wanted to make changes to this PR in a review, but I do not have the rights... (or I do not know how to do it :).

@cfries
Copy link
Contributor

cfries commented Feb 2, 2025

I do not understand why the tests are failing. This looks like a GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants