Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2935: Final system contract address #9287

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Jan 29, 2025

This PR updates the final EIP-2935 system contract address to a "nicer" looking one:
0x0000F90827F1C53a10cb7A02335B175320002935

The address follows the pattern 0x0000...00<eip-number> as for other pectra system contracts to make them more recognizable. The sender address for the deployment has been updated accordingly.
I've also tested the deployment of the contract on ephemery:
https://explorer.ephemery.dev/tx/0x67139a552b0d3fffc30c0fa7d0c20d42144138c8fe07fc5691f09c1cce632e15

Some alternative addresses (in case someone has a strong preference for one of these):

0x0000bb19fa6d960d31354746acaa6d7af1002935  (sig-s: 0x3b91ba580bc6a74599f236df59fcab658f004b)
0x0000503fa260ae9ceeead0152cc51302fd002935  (sig-s: 0x04b7656f3b2e13b25a2dd11aec146c64a2000c)

fun fact: these addresses were mined by users on the PoW faucet for sepolia/holesky over the last 2 months.

@pk910 pk910 requested a review from eth-bot as a code owner January 29, 2025 19:03
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Jan 29, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 29, 2025

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Jan 29, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used all the values included in this PR in EEST+EELS, and they seem to be working 👍

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eth-bot eth-bot enabled auto-merge (squash) January 30, 2025 15:55
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 569860c into ethereum:master Jan 30, 2025
23 checks passed
parithosh pushed a commit to ethpandaops/ethereum-genesis-generator that referenced this pull request Jan 31, 2025
Final update for pectra system contract addresses:

eip-2935:  `0x0000F90827F1C53a10cb7A02335B175320002935`
eip-7002:  `0x00000961Ef480Eb55e80D19ad83579A64c007002`
eip-7251:  `0x0000BBdDc7CE488642fb579F8B00f3a590007251`

gated on:
* [ ] ethereum/EIPs#9287
* [ ] ethereum/EIPs#9288
* [ ] ethereum/EIPs#9289
s1na pushed a commit to ethereum/go-ethereum that referenced this pull request Jan 31, 2025
s1na pushed a commit to s1na/go-ethereum that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants