Update EIP-7830: Move to Review #9265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
axic
commented
Jan 25, 2025
| @@ -60,16 +58,12 @@ A simple analysis shows contract deployements for 64 KiB contracts to be between | |||
|
|
|||
| Note that the Max 30M gas contract size of 135 KiB is outside the limits of what is proposed in this EIP and is included to show what it would take to exceed current gas limits. | |||
|
|
|||
| <!-- https://docs.google.com/spreadsheets/d/1C2dd5sVnZNKXOpRknHhxt6MnTTN50c3b9d6ZU2rvqDQ/edit?usp=sharing --> | |||
There was a problem hiding this comment.
@shemnon this is not accessible. If you want to make it public, can you post it on the magicians thread?
There was a problem hiding this comment.
Made viewable, but being in a comment it will be deleted when going to final/last call.
There was a problem hiding this comment.
It actually needs to deleted now going into review. Hence why I asked to post it on the magicians thread if it is still relevant.
There was a problem hiding this comment.
It's posted to the thread, you can delete.
axic
commented
Jan 25, 2025
| @@ -29,8 +29,6 @@ Storage cost is already paid per contract byte. | |||
|
|
|||
| [EIP-170](./eip-170.md) specifies `MAX_CODE_SIZE` as 24576 bytes, and [EIP-3860](./eip-3860.md) specifies `MAX_INITCODE_SIZE` as `2 * MAX_CODE_SIZE` (49152 bytes). | |||
|
|
|||
| <!-- TODO: if profiling analysis shows we need to charge more for EOF analysis, this is where we can specify it. Either globally or for 0xef00 contracs --> | |||
There was a problem hiding this comment.
Reminder: validation is only performed when a contract is brought in via a transaction. A factory create from an existing contract has no validation burden.
g11tech
approved these changes
Jan 27, 2025
eth-bot
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.