Update EIP-7723: Add "Declined for Inclusion" #9056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
abcoathup
reviewed
Nov 26, 2024
abcoathup
reviewed
Nov 26, 2024
EIPS/eip-7723.md
Outdated
| ### Context: Upgrade Meta EIPs | ||
|
|
||
| When planning a network upgrade, anyone **MAY** draft an Upgrade Meta EIP to list EIPs in various stages of consideration. This Meta EIP **SHOULD** include three categories in its specification section: `Proposed for Inclusion`, `Considered for Inclusion` and `Scheduled for Inclusion`. Even if a category is empty, it **SHOULD** be included in the initial draft for clarity. | ||
| When planning a network upgrade, anyone **MAY** draft an Upgrade Meta EIP to list EIPs in various stages of consideration. This Meta EIP **SHOULD** include four categories in its specification section: `Proposed for Inclusion`, `Rejected for Inclusion`, `Considered for Inclusion` and `Scheduled for Inclusion`. Even if a category is empty, it **SHOULD** be included in the initial draft for clarity. |
There was a problem hiding this comment.
Suggested change
| When planning a network upgrade, anyone **MAY** draft an Upgrade Meta EIP to list EIPs in various stages of consideration. This Meta EIP **SHOULD** include four categories in its specification section: `Proposed for Inclusion`, `Rejected for Inclusion`, `Considered for Inclusion` and `Scheduled for Inclusion`. Even if a category is empty, it **SHOULD** be included in the initial draft for clarity. | |
| When planning a network upgrade, anyone **MAY** draft an Upgrade Meta EIP to list EIPs in various stages of consideration. This Meta EIP **SHOULD** include four categories in its specification section: `Proposed for Inclusion`, `Declined for Inclusion`, `Considered for Inclusion` and `Scheduled for Inclusion`. Even if a category is empty, it **SHOULD** be included in the initial draft for clarity. |
abcoathup
reviewed
Nov 26, 2024
EIPS/eip-7723.md
Outdated
|
|
||
| When the Upgrade Meta EIP is moved to `Last Call`, the `Proposed for Inclusion` and `Considered for Inclusion` lists **SHOULD** be removed, leaving only `Scheduled for Inclusion`. | ||
| When the Upgrade Meta EIP is moved to `Last Call`, the `Proposed for Inclusion`, `Rejected for Inclusion` and `Considered for Inclusion` lists **SHOULD** be removed, leaving only `Scheduled for Inclusion`. |
There was a problem hiding this comment.
Suggested change
| When the Upgrade Meta EIP is moved to `Last Call`, the `Proposed for Inclusion`, `Rejected for Inclusion` and `Considered for Inclusion` lists **SHOULD** be removed, leaving only `Scheduled for Inclusion`. | |
| When the Upgrade Meta EIP is moved to `Last Call`, the `Proposed for Inclusion`, `Declined for Inclusion` and `Considered for Inclusion` lists **SHOULD** be removed, leaving only `Scheduled for Inclusion`. |
abcoathup
reviewed
Nov 26, 2024
abcoathup
reviewed
Nov 26, 2024
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
|
Thanks for the review, @abcoathup ! |
abcoathup
reviewed
Nov 27, 2024
|
@timbeiko we still need to amend the Scheduled for Inclusion, Included & Rationale sections to include DFI. |
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
eth-bot
approved these changes
Dec 5, 2024
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
Declined for Inclusionafter conversations at the L1 R&D workshop at Devcon. The purpose of this status is to signal that core devs with to explicitly exclude an EIP from a network upgrade and no longer discuss it as part of that upgrade's planning process. This already happens implicitly, where anything that isn'tCFI'd orSFI'd is considered rejected from the upgrade. TheDFIlabel makes this more explicit.This does not imply the EIP is "rejected forever": a DFI'd EIP can be proposed again for the next network upgrade.