Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4844: declare withdrawals in 4895 as a dependency #5906

Merged
merged 1 commit into from
Nov 10, 2022
Merged

EIP-4844: declare withdrawals in 4895 as a dependency #5906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions EIPS/eip-4844.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ status: Draft
type: Standards Track
category: Core
created: 2022-02-25
requires: 1559, 2718, 2930
requires: 1559, 2718, 2930, 4895
---

## Abstract
Expand Down Expand Up @@ -193,21 +193,22 @@ The resulting RLP encoding of the header is therefore:
```
rlp([
parent_hash,
ommers_hash,
0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347, # ommers hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to hardcode post-merge header values in this EIP we should maybe refer to EIP-3675 that defines them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was downstream of a request in 4895 to hardcode the values

I'm happy to add a note about the EIP, although if we want to standardize on this presentation then it will be a little silly to always reference 3675 in all future EIPs writing the header

coinbase,
state_root,
tx_root,
receipt_root,
bloom,
difficulty,
txs_root,
receipts_root,
logs_bloom,
0, # difficulty
number,
gas_limit,
gas_used,
time,
extra,
mix_digest,
nonce,
base_fee,
timestamp,
extradata,
prev_randao,
0x0000000000000000, # nonce
base_fee_per_gas,
withdrawals_root,
excess_data_gas
])
```
Expand Down