Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strengthen the discussion-url rules #4419

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Strengthen the discussion-url rules #4419

merged 1 commit into from
Nov 4, 2021

Conversation

axic
Copy link
Member

@axic axic commented Nov 4, 2021

Closes #2967.

@MicahZoltu MicahZoltu merged commit 4c13866 into master Nov 4, 2021
@MicahZoltu MicahZoltu deleted the discussion-url branch November 4, 2021 11:22
@alita-moore
Copy link
Contributor

@MicahZoltu did the bit not merge this automatically?

@MicahZoltu
Copy link
Contributor

MicahZoltu commented Nov 4, 2021 •
edited
Loading

It did not. I believe because we don't support auto merges of EIP-1?

PhABC pushed a commit to PhABC/EIPs that referenced this pull request Jan 25, 2022
@axic @PhABC
Strengthen the discussion-url rules (ethereum#4419)
e340e40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicahZoltu MicahZoltu MicahZoltu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EIP-1: Stronger rules for discussion-url
3 participants
@axic @alita-moore @MicahZoltu