-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muir Glacier postmortem report #2809
Closed
+134
−0
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
216fc28
Create Muir Glacier upgrade postmortem.md
poojaranjan 1ddbc82
Update Muir Glacier upgrade postmortem.md
poojaranjan 75ba8ee
Update and rename Muir Glacier upgrade postmortem.md to EIP-2809.md
poojaranjan 03184ee
Update and rename EIP-2809.md to eip-2809.md
poojaranjan 4e52f0f
Update EIPS/eip-2809.md
poojaranjan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| --- | ||
| eip: TBD | ||
| title: Muir Glacier upgrade postmortem report | ||
| author: James Hancock and Pooja Ranjan | ||
| discussions-to: https://ethereum-magicians.org/t/hard-fork-to-address-the-ice-age-eip-2387 | ||
| type: Informational | ||
| status: Draft | ||
| created: 2020-07-20 | ||
| --- | ||
|
|
||
| ## Abstract | ||
|
|
||
| To describe the process of preparing and activating the Muir Glacier network upgrade. | ||
|
|
||
| ## Motivation | ||
|
|
||
| Ethereum is growing and documentation of decisions & events that occurred during an upgrade process is extremely valuable. | ||
|
|
||
| ## Specification | ||
|
|
||
| ### Upgrade summary | ||
| * Date and time (in UTC): January 02, 2020 at 08:30:49 AM UTC | ||
| * Block Number (Mainnet): 9200000 | ||
| * Mined by: Spark Pool | ||
| * Block Reward: 2.04862589667520444 Ether (2 + 0.04862589667520444) | ||
| * Uncles Reward: 0 | ||
| * Difficulty: 2,458,589,766,091,800 | ||
| * Total Difficulty: 13,525,747,653,928,155,934,639 | ||
| * Block number (Ropsten): 7117117 | ||
|
|
||
| *Data collected from [Etherscan](https://etherscan.io/block/9200000).* | ||
|
|
||
|
|
||
| The Muir Glacier upgrade included the EIP for pushing back Ice Age. 3 out of 4 clients were perfect, and 4th client had a quick update after the fork without any negative effects. It took a day for block time to reduce to normal. | ||
|
|
||
| **Mainnet deployment before Ropsten** - Mainnet went to 17 second blocks instead of the forecast 19-20s blocks. Ropsten was at 28s per https://ropsten-stats.parity.io/ which was originally calculated for about 6 Jan or so. Ropsten slowdown and mainnet speedup was pretty much the opposite of expectations. | ||
|
|
||
|
|
||
| ### EIP Included | ||
|
|
||
| Muir Glacier had only one improvement proposal, [EIP 2384](https://eips.ethereum.org/EIPS/eip-2384). This EIP delayed the difficulty bomb for another 4,000,000 blocks so that the Ethereum chain doesn’t freeze/halt. | ||
|
|
||
| * Muir Glacier Fork meta: [EIP 2387](https://eips.ethereum.org/EIPS/eip-2387) | ||
|
|
||
| **Process of EIP selection** | ||
|
|
||
| Muir Glacier was an emergency upgrade required to address a situation which was imminent if not deployed quickly. Only one proposal was submitted, so not much of a selection was needed however developers did address relevant concerns and made appropriate adjustments for the numbers of blocks targeted to be pushed with the originally proposed EIP. | ||
|
|
||
| ### Timeline - Backlog check | ||
|
|
||
| Previously, the increase in difficulty level was [predicted](https://www.reddit.com/r/ethereum/comments/4iozgf/in_around_14_month_the_difficulty_bomb_will_make/d30c0lq/) to be coming in 2021. However, the events and landmarks in the Ethereum project were developing faster, and the difficulty bomb started to show-up earlier than expected. It became noticeable again on October 5th 2019 at block 8,600,000. Block times had been around 13.1s on average and as of block 8,900,000 were around 14.3s. It was predicted to accelerate exponentially every 100,000 blocks. | ||
|
|
||
| #### Discovery of problem | ||
| * Nov 13th - First brought to the attention of the Core devs https://gitter.im/ethereum/AllCoreDevs?at=5dcc599050010612b2b1b950 | ||
| * Nov 15h - ACD call [Agenda](https://github.com/ethereum/pm/issues/138), [Video](https://youtu.be/3qZFiETlDtk?t=3457) | ||
| * Nov 19th - block Time increases again - https://gitter.im/ethereum/AllCoreDevs?at=5dd4ce8050010612b2eeb9d6 | ||
|
|
||
| #### Validation of problem | ||
| * Nov 19th - Verified it is the Difficulty Bomb https://gitter.im/ethereum/AllCoreDevs?at=5dd4e00352b73c7cb24b54a5 | ||
| * Nov 20th - Confirmed https://gitter.im/ethereum/AllCoreDevs?at=5dd4ecba2c9bf5413e607488 | ||
|
|
||
| #### Discussion & decision making | ||
| * Nov 20th Discussed targeting Mid January | ||
| * Nov 20th - first discussion on Muir Glacier being its own fork after istanbul. - https://gitter.im/ethereum/AllCoreDevs?at=5dd542414941f9513fc23269 | ||
| * Nov 20th - EIP-2384 submitted | ||
| * Nov 22nd - Hard Fork Meta submitted under name Mountain Glacier - https://gitter.im/ethereum/AllCoreDevs?at=5dd8364699dfe74c958c75f7 | ||
| * Next Core Dev Call - https://github.com/ethereum/pm/issues/140 | ||
| * Nov 29th - First Suggestion of Muir Glacier - https://gitter.im/ethereum/AllCoreDevs?at=5de12f891659720ca8ca9de9 - Real link is in the Eth Magicians forum somewhere | ||
| * Nov 29th - 7117117 Ropsten Block number Suggested. Predicted 6th of Jan https://gitter.im/ethereum/AllCoreDevs?at=5de1317ab065c6433c08cf7d | ||
| * Nov 29th - Decision to not included PoA Chains because muir glacier never activates on PoA chains -- thus have zero impact on forkid | ||
| * Nov 29th - EIP-2384 and EIP-2387 moved to [Last Call](https://github.com/ethereum/EIPs/pull/2408) | ||
| * Dec 13th - [ACD meeting 77](https://github.com/ethereum/pm/blob/master/All%20Core%20Devs%20Meetings/Meeting%2077.md) The difficulty bomb (4 mil blocks) will be addressed at some point post Muir Glacier upgrade | ||
| * Dec 16th - [All clients ready](https://gitter.im/ethereum/AllCoreDevs?at=5df82418578ecf4b1fb7991a) | ||
| * Dec 16th - Ethereum [Muir Glacier Upgrade blog](https://medium.com/ethereum-cat-herders/ethereum-muir-glacier-upgrade-89b8cea5a210) published by the Ethereum cat Herders | ||
| * Dec 23rd - [Ethereum Muir Glacier Upgrade Announcement](https://blog.ethereum.org/2019/12/23/ethereum-muir-glacier-upgrade-announcement/) by EF | ||
| * Dec 30th - Nethermind and [Parity Ethereum nodes syncing issue](https://gitter.im/ethereum/AllCoreDevs?at=5e0abb7e2640a676295a0d6d) | ||
| * Dec 31st - [Parity Ethereum bug fixed](https://www.parity.io/new-parity-ethereum-update-protects-against-possible-attack/) | ||
| * Jan 02nd - [Community call](https://gitter.im/ethereum/AllCoreDevs?at=5e0da713eaa2cd096fde7365) for Muir Glacier | ||
| * Jan 02nd - [Nethermind's bug fixed](https://gitter.im/ethereum/AllCoreDevs?at=5e0ddf550fd3413f4c942e6c) | ||
|
|
||
| #### Implementation | ||
| * Jan 02, 2020: Activation on [Ethereum main network](https://etherscan.io/block/9200000) | ||
| * Jan 13, 2020: Activation on [Ropsten network](https://ropsten.etherscan.io/block/7117117) | ||
|
|
||
| ### Best Practices | ||
| * Have the EF reblog content from other sources | ||
|
|
||
| ### Suggested Corrective Action | ||
| (Problem and suggestions) | ||
|
|
||
| #### Testing window duration | ||
| The testing window planned was too short. We should avoid the mainnet to upgrade before testnet for any changes. | ||
|
|
||
| #### Ropsten Blocks being really irregular. | ||
| More aggressive calculation for difficulty bomb is required. Recommended research post is [here](https://ethresear.ch/t/deep-dive-into-current-pow-difficulty-adjustment-algorithm-and-a-possible-alternative/5267/12). | ||
|
|
||
| #### There isn’t a process for checking important dates/blocks for interclient coordination. | ||
| Suggested Solution: | ||
| * Data Checking list | ||
| * We take turns, Two others check numbers, posting the data and the process. People from this group sign up | ||
|
|
||
| #### Blocks are not predictable for timing things. | ||
| Suggested solution: | ||
| Time-Based forks. | ||
|
|
||
| #### Single Source of current info for main-net Variables | ||
| Suggestion Solution: | ||
| * Getting specific information about main-net variables Take a lot of digging in the EIP repo. Difficult to do. | ||
| * The Spec as of current EIPs in a Digest | ||
|
|
||
| #### Ethereum RedPhone Initiative | ||
| Suggestion Solution: | ||
| * Communicating from the CoreDevs out | ||
| * Pub/Sub model | ||
|
|
||
|
|
||
| ## Rationale | ||
|
|
||
| An informational EIP with upgrade analysis should help in visibility and traceability of the scope of changes as well as provide an easy accessibility of historic data for community reference. | ||
|
|
||
| ## Resources | ||
| * All Core Dev Gitter - https://gitter.im/ethereum/AllCoreDevs?at=5de7d9bf550662459868c742 | ||
| * Etherscan - https://etherscan.io/block/9200000 | ||
|
|
||
| ## Copyright | ||
|
|
||
| Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this formatting for authors is invalid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe either an email address or GitHub handle is required @lightclient, not just names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Theoretically" EIP-1 allows for only names in the author field. Not saying that's good though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL that handle/email is not required. 😄 Keep in mind, without that the bot will never auto-merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lightclient @MicahZoltu I've incorporated suggested changes yet 'All checks have failed', what am I missing?
Due to ongoing discussion of where this informational EIP should be stored, I understand it can't be merged just yet, but wondering about the correct format to be able to move beyond the bot check.