-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-1337 draft #2789
Add EIP-1337 draft #2789
Conversation
…ad a bytes meta argument added meta is defined as a 4 slot array, holding, address refundAddress, uint256 period, uint256 offChainID, uint256 expirationDate(unix timestamp) slots 0 and 1 are required, with slots 2 and 3 being optional, if 2 is not used but 3 is, 2 must be padded appropriately
Github seems to be stuck. |
9912f7c
to
b43e387
Compare
Stuck again. |
didnt check line by line this LGTM. |
Is there any time frame when this moves to the Final stage? |
@Aeroxander that's up to @owocki et al. If they're comfortable with where the standard is at, they are free to move it forward to last call. Two weeks after that, it will be eligible to be considered final. |
given that gitcoin grants has moved from subscriptions being a key feature to quadratic funding being the key feature, (+ we've actually removed subscription support bc it wasnt really used much) i dont see myself allocating more cycles to this. when we wrote the draft EIP, there was a whole working group (@androolloyd was my partner in crime + like 6 other ppl), but that has since stopped being active too. sorry i know thats not the answer you were looking to hear, but im just trying to be deliberate about setting expectations. would be happy to pass the baton to someone new! |
* eip 1337 draft * EIP-1337 Draft updated to reflect standards and current version of proposal * authors -> author * update of contributors * code review turnaround * EIP getSubscriptionHash and execSubscription have been modified and had a bytes meta argument added meta is defined as a 4 slot array, holding, address refundAddress, uint256 period, uint256 offChainID, uint256 expirationDate(unix timestamp) slots 0 and 1 are required, with slots 2 and 3 being optional, if 2 is not used but 3 is, 2 must be padded appropriately * cleanup for Andrew * fix errors in 1337 * add discussion thread * add status and fix spelling bugs * remove eip-948 refs * remove .idea from gitignore Co-authored-by: Owocki <ksowocki@gmail.com> Co-authored-by: Andrew Redden <andrew@blockcrushr.com> Co-authored-by: Nathan Creswell <nathantr@users.noreply.github.com> Co-authored-by: Austin <austin.griffith@madwiremedia.com>
* eip 1337 draft * EIP-1337 Draft updated to reflect standards and current version of proposal * authors -> author * update of contributors * code review turnaround * EIP getSubscriptionHash and execSubscription have been modified and had a bytes meta argument added meta is defined as a 4 slot array, holding, address refundAddress, uint256 period, uint256 offChainID, uint256 expirationDate(unix timestamp) slots 0 and 1 are required, with slots 2 and 3 being optional, if 2 is not used but 3 is, 2 must be padded appropriately * cleanup for Andrew * fix errors in 1337 * add discussion thread * add status and fix spelling bugs * remove eip-948 refs * remove .idea from gitignore Co-authored-by: Owocki <ksowocki@gmail.com> Co-authored-by: Andrew Redden <andrew@blockcrushr.com> Co-authored-by: Nathan Creswell <nathantr@users.noreply.github.com> Co-authored-by: Austin <austin.griffith@madwiremedia.com>
Hello @owocki, I have a team that is interested in subscription payments. I would love to have a chat with picking up the baton since this is so close to the finish line. |
@davidtai Please use the discussions-to link in the EIP for further discussion. |
Per this comment and the tweet that recently put EIP-1337 back under the spotlight, it would be nice for this to be merged as a draft. Rendered.