-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sketch out genesis predeploy check #373
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For OP Mainnet, or in fact for any chain, if the genesis allocs are not present we have the option to go on chain (L2) and query for the information. |
geoknee
force-pushed
the
gk/genesis-predeploy-check
branch
from
July 17, 2024 12:03
299884b
to
5d766e0
Compare
geoknee
commented
Jul 17, 2024
Comment on lines
+129
to
+132
g, err := LoadGenesis(chain.ChainID) | ||
require.NoError(t, err) | ||
|
||
ch := g.Alloc[MustHexToAddress(implementation)].CodeHash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #372
To get this over the line, I think the blockers are as follows:
exclusions_test.go
) or downgrade any chain failing the check