fix(bindings): Split out Primitive Types #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
approved these changes
Jun 13, 2024
sebastianst
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Only reviewed the very few non-rust changes. Deferring to @clabby's rust review otherwise.
This was referenced Jun 25, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits primitive types from the rust bindings so they can be used without serde enabled in
kona. This makes primitive types here portable for downstream non-serde applications.This pr also
RollupConfigdefinition fromkonato the superchain registry.SystemConfigdefinition fromkonato the superchain registry.ChainGenesisgeneric and removeskona'sGenesistype.GenesisSytemConfigandSystemConfig, making fields optional where needed.Metadata
Fixes op-rs/kona#219