Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interop start timestamp explainer to spec docs #324

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

AmadiMichael
Copy link
Member

Description

This pr adds the concept of Interop Start Timestamp to the Specs.

Metadata

@@ -117,6 +129,7 @@ A simple implementation of the `executeMessage` function is included below.
function executeMessage(Identifier calldata _id, address _target, bytes calldata _msg) public payable {
require(_id.timestamp <= block.timestamp);
require(L1Block.isInDependencySet(_id.chainid));
require(_id.timestamp > L1Block.interopStart());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could choose to put this value directly in the CrossL2Inbox to save a call, what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think its worth the gas savings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, this already exists in Crossl2Inbox and not L1Block, it's my mistake in the reference implementation

@tynes
Copy link
Contributor

tynes commented Aug 12, 2024

This doesn't match the implemention exactly in the pseudocode

ethereum-optimism/optimism#11398

We should migrate more pseudocode to natural language when it makes sense to but no need to do that now for this

I think the implementation it the right way to do it

@tynes tynes merged commit 7870900 into main Aug 13, 2024
1 check passed
@tynes tynes deleted the interop-start-timestamp branch August 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants