contracts-bedrock: visibility into flake #8072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A flake in CI was introduced when #7928 was merged. It is probably due to a race condition when reading a file from disk. Is there a way to have foundry only do something once for the entire test suite? Tried moving things to the constructor instead of `setUp` but that did not work. Ideally we do not need to read the file from disk for each contract deployed, this adds a lot of overhead. A solution around this is to refactor the way that the deploy script works or to add in the env var that will skip the check that sometimes fails.
Codecov Report
@@ Coverage Diff @@
## develop #8072 +/- ##
===========================================
- Coverage 46.07% 42.10% -3.98%
===========================================
Files 170 122 -48
Lines 7121 4741 -2380
Branches 1138 987 -151
===========================================
- Hits 3281 1996 -1285
+ Misses 3713 2672 -1041
+ Partials 127 73 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
|
maurelian
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A flake in CI was introduced when #7928
was merged. It is probably due to a race condition when reading a file
from disk. Is there a way to have foundry only do something once for the
entire test suite? Tried moving things to the constructor instead of
setUpbut that did not work. Ideally we do not need to read the filefrom disk for each contract deployed, this adds a lot of overhead.
A solution around this is to refactor the way that the deploy script
works or to add in the env var that will skip the check that sometimes
fails.