-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary tsconfig arguments #798
Conversation
|
Requesting that @gakonst take a look at this -- was this something you added? |
this is useful so that your IDE/editor can have code navigation/completion features just by cloning the repo, without requiring you to build it.
The |
"paths": { | ||
"@eth-optimism/*": ["packages/*/src", "integration-tests/*/test"] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this. OK with removing the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This affects certain packages behaviour. For example, running tslint
in packages/contracts
will lead to linting of packages/smock
I think because it interprets it as part of the source code. I haven't fully debugged that example in particular but removing this line fixes it.
Do we need that feature? I prefer building the packages and using TypeScript's Project References.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KK - was thinking it's a better experience, but if it's a PITA np.
* style: fix indenting * build: remove skipLibCheck, paths, and baseUrl from base typescript config
Removes skipLibCheck, paths, and baseUrl from base typescript config. It's not clear from the commit history why these were added, and the integration tests have passed for me locally on a fresh build with these changes added.