Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch-submitter: remove call to appendQueueBatch #1346

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Aug 17, 2021

Description

The batch submitter is normally ran without running the call to
appendQueueBatch. The contracts have appendQueueBatch disabled
currently. This means that calling appendQueueBatch will result
in a revert. This PR removes the config option that is responsible
for turning of the call to appendQueueBatch so it is more likely
to "just work".

The batch submitter is normally ran without running the call to
`appendQueueBatch`. The contracts have `appendQueueBatch` disabled
currently. This means that calling `appendQueueBatch` will result
in a revert. This PR removes the config option that is responsible
for turning of the call to `appendQueueBatch` so it is more likely
to "just work".
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2021

🦋 Changeset detected

Latest commit: 39cea8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/batch-submitter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tynes
Copy link
Contributor Author

tynes commented Sep 21, 2021

appendQueueBatch is disabled in the contracts so removing this code reduces the amount of config we need for the batch submitter. Feels like we can add this code back once the functionality is there

@tynes tynes requested a review from maurelian September 27, 2021 16:38
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tynes tynes merged commit c891827 into develop Sep 27, 2021
@tynes tynes deleted the fix/remove-append-queuebatch branch September 27, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-batcher Area: op-batcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants