fix(ci): add files to semgrep ignore #12219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaultDisputeGame and PermissionedDisputeGame interface files are annoying because the semgrep ignore comment doesn't seem to work properly.
888cd21 to
a20b17f
Compare
ajsutton
approved these changes
Oct 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12219 +/- ##
===========================================
- Coverage 75.19% 74.97% -0.22%
===========================================
Files 49 49
Lines 3665 3665
===========================================
- Hits 2756 2748 -8
- Misses 736 745 +9
+ Partials 173 172 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
FaultDisputeGame and PermissionedDisputeGame interface files are annoying because the semgrep ignore comment doesn't seem to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FaultDisputeGame and PermissionedDisputeGame interface files are annoying because the semgrep ignore comment doesn't seem to work properly.