-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add retry.Do0
#12194
add retry.Do0
#12194
Conversation
30d3638
to
3a02b1d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12194 +/- ##
===========================================
- Coverage 75.19% 74.97% -0.22%
===========================================
Files 49 49
Lines 3656 3656
===========================================
- Hits 2749 2741 -8
- Misses 734 743 +9
+ Partials 173 172 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
I like the idea, but nothing is actually using it. Are the places in the code that should be updated to use the new |
It was my code outside that wanted to reuse retry package in the monorepo, but I also find two places in the monorepo that can be refactored to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
f2d5e32
The
Do
andDo2
expects a function that returns(T,error)
and(T,U,error)
respectively.This PR adds a
Do0
function that accepts a function that returnserror
only, which is handy in many cases.