Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op-conductor): implement startup handshake #12047

Conversation

0x00101010
Copy link
Collaborator

@0x00101010 0x00101010 commented Sep 22, 2024

Description

Implement startup handshake, this is used to make sure that both conductor and sequencer are configured properly in HA setup.

This PR prevents the situation that conductor is configured and running, but op-node did not enable conductor, this situation allows conductor to control (start / stop) sequencer, but not with sequencer committing unsafe payload into conductor, which is dangerous in faulty situations.

For op-conductor:

  1. Waits for op-node to start
  2. if cannot reach op-node, exit
  3. check if conductor is enabled on op-node, if not, exit

Tests

  1. Covered by existing e2e tests.
  2. Tested in testnet

Metadata

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (73534e2) to head (291f287).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12047   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files           49       49           
  Lines         3656     3656           
========================================
  Hits          2741     2741           
  Misses         743      743           
  Partials       172      172           
Flag Coverage Δ
cannon-go-tests 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@0x00101010 0x00101010 force-pushed the feat/conductor-node-startup-dance branch from a6e6f7c to 39c72b0 Compare September 22, 2024 21:48
@0x00101010 0x00101010 marked this pull request as ready for review September 23, 2024 03:15
@0x00101010 0x00101010 requested review from a team as code owners September 23, 2024 03:15
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems generally good but will defer to a code owner to approve

@0x00101010 0x00101010 force-pushed the feat/conductor-node-startup-dance branch from 561ac06 to 291f287 Compare September 26, 2024 22:11
@protolambda protolambda added this pull request to the merge queue Sep 26, 2024
Merged via the queue into ethereum-optimism:develop with commit d83f12d Sep 26, 2024
63 checks passed
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
)

* op-node waits establishes connection to conductor before starting in sequencer enabled mode

* Added conductor enabled api to op-node

* check node enabled conductor during conductor startup

* update logs

* Change back to lazy initialization

* Add method not found check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants