-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(op-conductor): implement startup handshake #12047
feat(op-conductor): implement startup handshake #12047
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12047 +/- ##
========================================
Coverage 74.97% 74.97%
========================================
Files 49 49
Lines 3656 3656
========================================
Hits 2741 2741
Misses 743 743
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
a6e6f7c
to
39c72b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems generally good but will defer to a code owner to approve
…sequencer enabled mode
561ac06
to
291f287
Compare
d83f12d
Description
Implement startup handshake, this is used to make sure that both conductor and sequencer are configured properly in HA setup.
This PR prevents the situation that conductor is configured and running, but op-node did not enable conductor, this situation allows conductor to control (start / stop) sequencer, but not with sequencer committing unsafe payload into conductor, which is dangerous in faulty situations.
For op-conductor:
Tests
Metadata