Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: 64-bit Refactor #12029

Merged
merged 11 commits into from
Oct 1, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more review comments
Inphi committed Oct 1, 2024
commit aabd85186786914d6dd56d0b0963e8f4b8a0f086
2 changes: 1 addition & 1 deletion cannon/mipsevm/exec/mips_syscalls.go
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ const (
AddressMask = arch.AddressMask
)

// TODO: redefine syscalls for MIPS64
// TODO(#12205): redefine syscalls for MIPS64
// Syscall codes
const (
SysMmap = 4090
2 changes: 1 addition & 1 deletion cannon/mipsevm/multithreaded/mips.go
Original file line number Diff line number Diff line change
@@ -185,7 +185,7 @@ func (m *InstrumentedState) handleSyscall() error {
case exec.SysSigaltstack:
case exec.SysRtSigaction:
case exec.SysPrlimit64:
// TODO: may be needed for 64-bit Cannon
// TODO(#12205): may be needed for 64-bit Cannon
// case exec.SysGetRtLimit:
case exec.SysClose:
case exec.SysPread64:
2 changes: 0 additions & 2 deletions ops/docker/op-stack-go/Dockerfile.dockerignore
Original file line number Diff line number Diff line change
@@ -2,8 +2,6 @@
# node_modules, packages (contains git submodules and node modules etc.), devnet dirs etc. all add up a lot.
*

# keep .git for multicannon
!/.git
!/cannon
!/op-batcher
!/op-bootnode