OPSM: Dedupe some code, switch to getter methods for added safety #11555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tters, and add corresponding tests
tynes
reviewed
Aug 22, 2024
tynes
approved these changes
Aug 22, 2024
Base automatically changed from
opsm/deploy-implementation-contracts
to
develop
August 22, 2024 15:34
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…hereum-optimism#11555) * feat: scaffold impl deploy script and test * add fault proofs support * appease semgrep * additional semgrep fix * refactor: dedupe libraries * refactor/test: refactor to use getter methods to add assertions on getters, and add corresponding tests * fix url * chore: ignore autogenerated lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #11539
This PR makes the following changes:
DeployUtilslibrary. We intentionally use a new library to keep these new deploy scripts separated from the original, to make cleaning up the old scripts simpler.Solarraylibrary which is based on https://github.com/emo-eth/solarray as described in the comments of our newSolarray.sol. While adding that library is arguably overkill for the changes in this PR, I added it because in the long term I believe we can use it to clean up the test suite by improving solidity array UX.publicfunction. Users can compose these functions, but some of these functions depend on other functions be ran first (for example, you can't deployMIPSuntil you deployPreimageOracle, because the latter is a constructor argument for the former). Therefore this "assert on read" pattern helps prevent footguns where users may end up deploying an invalid or misconfigured system.Edit: commit history is messed up here, the first five commits are from #11539 since this branch was built off that. Since we squash merge I've just left the history alone