fix: remove the payable from the sendMessage
#11543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payable modifier from the sendMessagepayable from the sendMessage
|
Good catch. Can you bump the semver in the contract to |
|
Would be great to add a test that ensures the method reverts when sent ETH, to avoid future regressions |
|
I added a new test case to ensure it reverts when sent ETH and also run |
mds1
reviewed
Aug 22, 2024
packages/contracts-bedrock/test/L2/L2ToL2CrossDomainMessenger.t.sol
Outdated
Show resolved
Hide resolved
|
Thanks! You just need to run optimism/packages/contracts-bedrock/justfile Lines 67 to 68 in bcc734b @tynes It looks like this is not run as part of of |
tynes
approved these changes
Aug 23, 2024
|
Thank you for this! |
Merged
via the queue into
ethereum-optimism:develop
with commit Aug 23, 2024
9cd71a5
58 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…1543) * fix: remove the `payable` from the `sendMessage` * chore: bump L2ToL2CrossDomainMessenger version into 1.0.0-beta.3 * refactor: using encodeCall() instead of encodeWithSelector()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove the
payablemodifier from thesendMessageensure this implementation stays consistent with the specs
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata