Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add backoff to driver.go alt-da put request fail logic #11534

Closed
wants to merge 1 commit into from

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Aug 20, 2024

Description

When the put request to the da-server fails, it the batch submitter puts back the frames into their respective channel builder, and returns nil (instead of err). This was probably added to allow the driver to retry sending the blob to the server immediately, without having to wait until the next poll. However, this is very bad behavior as clients should typically linear or exponential backoff when retrying requests, which this code doesn't do.

** Solution **

Returning the err will make the for loop return, and wait for the next poll before retrying to send blobs to the da server.

Tests

Have not added any tests. This is a fairly simple change.
It might have unintended consequences though, so I'd be happy to know if there's some tests I should run.

Additional context

Here is my op-batcher sending a gazillion (500 returning) requests in a very short amount of time to the eigenda-proxy (our da-server):
image
image

Metadata

  • Fixes #[Link to Issue]

@samlaf samlaf requested a review from a team as a code owner August 20, 2024 06:39
@samlaf samlaf requested a review from mslipper August 20, 2024 06:39
@tynes
Copy link
Contributor

tynes commented Aug 22, 2024

I would like to build a little more confidence in this being the solution given the work going on in celo-org#213 before merging

@samlaf
Copy link
Contributor Author

samlaf commented Aug 22, 2024

@tynes this is not related to parallel blob submission. This is just fixing a problem with the current sequential submission implementation.
But if you're saying that you'd prefer to wait until we have a parallel blob submission PR ready before merging anything at all, then that's also fine with me.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 5, 2024
@github-actions github-actions bot closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants