Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ctb): add rationale to comment #11429

Merged
merged 1 commit into from
Aug 9, 2024
Merged

chore(ctb): add rationale to comment #11429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/contracts-bedrock/scripts/L2Genesis.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,10 @@ contract L2Genesis is Deployer {
/// The Proxy bytecode should be set. All proxied predeploys should have
/// the 1967 admin slot set to the ProxyAdmin predeploy. All defined predeploys
/// should have their implementations set.
/// Warning: the predeploy accounts have contract code, but 0 nonce value.
/// Warning: the predeploy accounts have contract code, but 0 nonce value, contrary
/// to the expected nonce of 1 per EIP-161. This is because the legacy go genesis
// script didn't set the nonce and we didn't want to change that behavior when
/// migrating genesis generation to Solidity.
function setPredeployProxies() public {
console.log("Setting Predeploy proxies");
bytes memory code = vm.getDeployedCode("Proxy.sol:Proxy");
Expand Down