fix(op-batcher): support new fjord maxRLPBytesPerChannelFjord via rollup chain spec #11169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
reviewed
Jul 18, 2024
6a050f1 to
1ab9b4c
Compare
protolambda
approved these changes
Jul 19, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Jul 21, 2024
6dfe4b0
63 checks passed
|
Worth to mention that this fix was possible collaborating with Derive (former Lyra) team which was exploring higher gas block limits (120M). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Fjord bump 10x
MaxRLPBytesPerChannelto support higher gas limits.On derivation the new limit is supported but op-batcher still use the old value.
This can lead to situation where the batcher halt in a chain post-Fjord with high block gas limit when a block bigger than 10M(bytes) is produced (this because a block cannot span today more than 1 channel).
This fixes #10428 using the new value when appropriated and remove legacy
SafeMaxRLPBytesPerChannel.In the comments on the channel builder there a note about the choice of timestamp.