Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: batch-decoder: Fjord Frame Timestamp fix #11143

Conversation

pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented Jul 12, 2024

Description

Two fixes;

  • derive.BatchReader got aware of channel's timestamp(or frame's timestamp) starting from Fjord network upgrade. Batch decoder manually reconstructs frames from json, and previously it did not supply frame timestamps because it was not necessary for pre-Fjord. Now we need the correct timestamp.
  • Fixed json key typo for compression algos, for channels.

Tests

Manually tested at the first Fjord op-mainnet batch.

First fetch batch transaction.

./batch_decoder fetch --start=20277208 --end=20278210 --sender=0x6887246668a3b87F54DeB3b94Ba47a6f63F32985  --inbox=0xFF00000000000000000000000000000000000010 --l1=[L1_RPC] --l1.beacon=[L1_BEACON]

Then reassemble to make a channel.

./batch_decoder reassemble --inbox=0xFF00000000000000000000000000000000000010 --in=/tmp/batch_decoder/transactions_cache

Before this patch, batch decoder emitted Err: cannot accept brotli compressed batch before Fjord error, and stores channels which contains no batches. After this patch, It correctly stores batches and compression algos.

@pcw109550 pcw109550 marked this pull request as ready for review July 12, 2024 22:50
@pcw109550 pcw109550 requested a review from a team as a code owner July 12, 2024 22:50
@pcw109550 pcw109550 requested a review from sebastianst July 12, 2024 22:50
@tynes tynes added this pull request to the merge queue Jul 22, 2024
Merged via the queue into ethereum-optimism:develop with commit 5ae06b0 Jul 22, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants