op-node: batch-decoder: Fjord Frame Timestamp fix #11143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two fixes;
derive.BatchReader
got aware of channel's timestamp(or frame's timestamp) starting from Fjord network upgrade. Batch decoder manually reconstructs frames from json, and previously it did not supply frame timestamps because it was not necessary for pre-Fjord. Now we need the correct timestamp.Tests
Manually tested at the first Fjord op-mainnet batch.
First fetch batch transaction.
Then reassemble to make a channel.
Before this patch, batch decoder emitted
Err: cannot accept brotli compressed batch before Fjord
error, and stores channels which contains no batches. After this patch, It correctly stores batches and compression algos.