feat: enable customization of L1/L2 chain info #10730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally this PR will add |
protolambda
approved these changes
Jun 4, 2024
protolambda
reviewed
Jun 4, 2024
protolambda
approved these changes
Jun 4, 2024
tynes
approved these changes
Jun 4, 2024
Merged
via the queue into
ethereum-optimism:develop
with commit Jun 4, 2024
5db8adf
64 checks passed
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
* feat: enable customization of L1/L2 chain info * add faultGameWithdrawalDelay * Update config.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables anyone to customize the L1 ChainID and L1 block time. (As well as for L2)
This is useful when you want to deploy on a custom L1 network. (Possibly with a different seconds per slot config parameter).
Not sure where this value plays a role in. Would be good to verify that this could be dynamically adjusted based on the L1s seconds_per_slot param.
"finalizationPeriodSeconds": 12,