more review comments

ethereum-optimism · Oct 1, 2024 · aabd851 · aabd851
1 parent 940bc42
commit aabd851
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/cannon/mipsevm/exec/mips_syscalls.go b/cannon/mipsevm/exec/mips_syscalls.go
@@ -19,7 +19,7 @@ const (
 	AddressMask = arch.AddressMask
 )
 
-// TODO: redefine syscalls for MIPS64
+// TODO(#12205): redefine syscalls for MIPS64
 // Syscall codes
 const (
 	SysMmap         = 4090

diff --git a/cannon/mipsevm/multithreaded/mips.go b/cannon/mipsevm/multithreaded/mips.go
@@ -185,7 +185,7 @@ func (m *InstrumentedState) handleSyscall() error {
 	case exec.SysSigaltstack:
 	case exec.SysRtSigaction:
 	case exec.SysPrlimit64:
-	// TODO: may be needed for 64-bit Cannon
+	// TODO(#12205): may be needed for 64-bit Cannon
 	// case exec.SysGetRtLimit:
 	case exec.SysClose:
 	case exec.SysPread64:

diff --git a/ops/docker/op-stack-go/Dockerfile.dockerignore b/ops/docker/op-stack-go/Dockerfile.dockerignore
@@ -2,8 +2,6 @@
 # node_modules, packages (contains git submodules and node modules etc.), devnet dirs etc. all add up a lot.
 *
 
-# keep .git for multicannon
-!/.git
 !/cannon
 !/op-batcher
 !/op-bootnode