Skip to content

Commit

Permalink
clear leftover for op-bindings (#11123)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhiqiangxu authored Jul 10, 2024
1 parent 67b8ee5 commit 77e562c
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 19 deletions.
1 change: 0 additions & 1 deletion .coderabbit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ reviews:
collapse_walkthrough: true
path_filters:
- "!**/*.json"
- "!op-bindings/bindings/**"
path_instructions:
- path: "**.sol"
instructions: "Focus on the following areas:
Expand Down
7 changes: 0 additions & 7 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,6 @@ pull_request_rules:
label:
add:
- A-op-batcher
- name: Add A-op-bindings label
conditions:
- 'files~=^op-bindings/'
actions:
label:
add:
- A-op-bindings
- name: Add A-op-bootnode label
conditions:
- 'files~=^op-bootnode/'
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ packages/contracts-bedrock/deployments/anvil

coverage.out

# Ignore bedrock go bindings local output files
op-bindings/bin

__pycache__

Expand Down
1 change: 0 additions & 1 deletion .semgrepignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ tests/
# Semgrep-action log folder
.semgrep_logs/

op-bindings/bindings/

packages/*/node_modules
packages/*/test
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ submodules:
git submodule update --init --recursive
.PHONY: submodules

op-bindings:
make -C ./op-bindings
.PHONY: op-bindings

op-node:
make -C ./op-node op-node
Expand Down
1 change: 0 additions & 1 deletion codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ comment:

ignore:
- "op-e2e"
- "op-bindings/bindings/*.go"
- "**/*.t.sol"
- "packages/contracts-bedrock/test/**/*.sol"
- "packages/contracts-bedrock/scripts/**/*.sol"
Expand Down
1 change: 0 additions & 1 deletion op-plasma/Dockerfile.dockerignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
*

!/op-bindings
!/op-service
!/op-plasma
!/go.mod
Expand Down
4 changes: 2 additions & 2 deletions op-service/predeploys/addresses_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
)

func TestGethAddresses(t *testing.T) {
// We test if the addresses in geth match those in op-bindings, to avoid an import-cycle:
// we import geth in the monorepo, and do not want to import op-bindings into geth.
// We test if the addresses in geth match those in op monorepo, to avoid an import-cycle:
// we import geth in the monorepo, and do not want to import op monorepo into geth.
require.Equal(t, L1BlockAddr, types.L1BlockAddr)
}
1 change: 0 additions & 1 deletion ops/docker/op-stack-go/Dockerfile.dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

!/cannon
!/op-batcher
!/op-bindings
!/op-bootnode
!/op-chain-ops
!/op-challenger
Expand Down

0 comments on commit 77e562c

Please sign in to comment.