Skip to content

Commit

Permalink
cleanup: rm more js (#11260)
Browse files Browse the repository at this point in the history
* deps: pull js together

Puts all js in the single package where it is used

* deps: move linting config

* nx: remove config

* changesets: remove

* npmignore: remove

* npmrc: remove workspace

* ci: cleanup

* check-changed: remove nx dep

* build: attempt fix

* ci: cleanup
  • Loading branch information
tynes authored Jul 29, 2024
1 parent d837696 commit 5b13bad
Show file tree
Hide file tree
Showing 15 changed files with 3,865 additions and 3,572 deletions.
41 changes: 4 additions & 37 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ jobs:
- "node_modules"
- run:
name: Install dependencies
command: pnpm install:ci:offline
command: pnpm install
- run:
name: print forge version
command: forge --version
Expand Down Expand Up @@ -579,7 +579,8 @@ jobs:
# populate node modules from the cache
- run:
name: Install dependencies
command: pnpm install:ci
command: pnpm install
working_directory: packages/contracts-bedrock
- run:
name: forge version
command: forge --version
Expand Down Expand Up @@ -687,48 +688,14 @@ jobs:
- attach_workspace: { at: "." }
- run:
name: Install dependencies
command: pnpm install:ci
command: pnpm install
- check-changed:
patterns: contracts-bedrock
- run:
name: validate spacers
command: pnpm validate-spacers
working_directory: packages/contracts-bedrock

js-lint-test:
parameters:
package_name:
description: Package name
type: string
dependencies:
description: Regex matching dependent packages
type: string
default: this-package-does-not-exist
docker:
- image: <<pipeline.parameters.ci_builder_image>>
resource_class: large
steps:
- checkout
- attach_workspace: { at: "." }
- restore_cache:
name: Restore PNPM Package Cache
keys:
- pnpm-packages-v2-{{ checksum "pnpm-lock.yaml" }}
- check-changed:
patterns: <<parameters.package_name>>,<<parameters.dependencies>>
# populate node modules from the cache
- run:
name: Install dependencies
command: pnpm install:ci
- run:
name: Lint
command: pnpm lint && git diff --exit-code
working_directory: packages/<<parameters.package_name>>
- run:
name: Test
command: pnpm test
working_directory: packages/<<parameters.package_name>>

todo-issues:
machine:
image: <<pipeline.parameters.base_image>>
Expand Down
185 changes: 0 additions & 185 deletions .eslintrc.js

This file was deleted.

1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ node_modules
results
temp
coverage.json
*.tsbuildinfo
**/lcov.info

yarn-error.log
Expand Down
1 change: 0 additions & 1 deletion .npmrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@
# npm and yarn support this as a default pnpm defaults to false
enable-pre-post-scripts=true
lockfile=true
prefer-workspace-packages=true
20 changes: 0 additions & 20 deletions .pnpmfile.cjs

This file was deleted.

85 changes: 0 additions & 85 deletions nx.json

This file was deleted.

3 changes: 0 additions & 3 deletions ops/check-changed/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
r'^package\.json',
r'ops/check-changed/.*',
]
with open("../../nx.json") as file:
nx_json_data = json.load(file)
REBUILD_ALL_PATTERNS += nx_json_data["implicitDependencies"].keys()

GO_PATTERNS = [
r'^go\.mod',
Expand Down
Loading

0 comments on commit 5b13bad

Please sign in to comment.