Skip to content

Commit

Permalink
add rationale to comment (#11429)
Browse files Browse the repository at this point in the history
  • Loading branch information
mds1 authored Aug 9, 2024
1 parent b1dfa22 commit 586e662
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/contracts-bedrock/scripts/L2Genesis.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,10 @@ contract L2Genesis is Deployer {
/// The Proxy bytecode should be set. All proxied predeploys should have
/// the 1967 admin slot set to the ProxyAdmin predeploy. All defined predeploys
/// should have their implementations set.
/// Warning: the predeploy accounts have contract code, but 0 nonce value.
/// Warning: the predeploy accounts have contract code, but 0 nonce value, contrary
/// to the expected nonce of 1 per EIP-161. This is because the legacy go genesis
// script didn't set the nonce and we didn't want to change that behavior when
/// migrating genesis generation to Solidity.
function setPredeployProxies() public {
console.log("Setting Predeploy proxies");
bytes memory code = vm.getDeployedCode("Proxy.sol:Proxy");
Expand Down

0 comments on commit 586e662

Please sign in to comment.