Merge pull request #62 from mariobyn/ns/replaced-transfer-with-call

Replaced transfer with call
ethereum-optimism · Mar 10, 2022 · 24c78db · 24c78db
2 parents 50997dd + c1268e2
commit 24c78db
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/contracts/Challenge.sol b/contracts/Challenge.sol
@@ -48,8 +48,9 @@ contract Challenge {
   fallback() external payable {}
   receive() external payable {}
   function withdraw() external {
-    require(msg.sender == owner);
-    owner.transfer(address(this).balance);
+    require(msg.sender == owner, "not owner");
+    (bool sent, ) = owner.call{value: address(this).balance}("");
+    require(sent, "Failed to send Ether");
   }
 
   // create challenge
@@ -211,8 +212,9 @@ contract Challenge {
     require(stepState == c.assertedState[c.R], "wrong asserted state for challenger");
 
     // pay out bounty!!
-    c.challenger.transfer(address(this).balance);
-
+    (bool sent, ) = c.challenger.call{value: address(this).balance}("");
+    require(sent, "Failed to send Ether");
+
     emit ChallengerWins(challengeId);
   }