-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interop: Ingress Filtering for Interop Enabled Mempool #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelKingsley
requested review from
protolambda
and removed request for
a team
October 29, 2024 20:54
axelKingsley
force-pushed
the
interop-mempool-filter
branch
from
October 29, 2024 22:21
91583bf
to
0bbcfdd
Compare
This was referenced Oct 29, 2024
protolambda
force-pushed
the
interop-sequencer-check
branch
from
October 31, 2024 18:07
e63bca4
to
c4d09bc
Compare
tyler-smith
reviewed
Nov 1, 2024
protolambda
force-pushed
the
interop-mempool-filter
branch
3 times, most recently
from
November 1, 2024 10:01
8549c50
to
ef9a639
Compare
Co-authored-by: Tyler Smith <mail@tcry.pt> Co-authored-by: Diederik Loerakker <proto@protolambda.com>
protolambda
force-pushed
the
interop-mempool-filter
branch
from
November 1, 2024 10:05
ef9a639
to
007538b
Compare
Rebased this, squashed the commits, moved some interop logic into its own file + documented it in the fork.yaml.
|
axelKingsley
force-pushed
the
interop-mempool-filter
branch
from
November 5, 2024 04:52
ed40f84
to
262842b
Compare
protolambda
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Creates components for filtering Transactions out of the mempool if they create invalid Executing Messages
Ingress Filters
In the
txpool
package,IngressFilter
s take a Tx and return a boolean if the tx is acceptable to move forward.InteropFilter
An implementation of an Ingress Filter, this takes and uses two functions to collect logs for the given Tx and ask the Supervisor about the validity of them.
txpool
TXPools now hold a slice of Ingress Filters. When calling
Add
, each transaction is passed through each filter, and if a filter would drop the transaction it is noted, and returned as a newFilteredOut
error.Ethereum Backend
The backend now features a function to get logs by simulating a transaction, called
SimLogs
. When creating a new backend, if Interop is enabled, the TX Pool is given an InteropFilter which is attached to theSimLogs
andCheckMessages
functions.TODO:
core
components. I based this function on code in the Tracing components. EDIT: the best way will probably be to develop and E2E test in the monorepo which demonstrates it