feat: Add superchainconfig fetched from env variables. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have added a new required arg.
We can use it from environnement with
PSPEXECUTOR_MON_SUPERCHAINCONFIG_ADDRESSor from the cli:--superchainconfig.address.To use it, we can do:
export PSPEXECUTOR_MON_SUPERCHAINCONFIG_ADDRESS=0xC2Be75506d5724086DEB7245bd260Cc9753911BeI have also updated the tests accordingly and make sure the values will be printed at the start of the service.
Tests
I have run the tests and modified to test to ensure this is taking in consideration this arguments.
Additional context