Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up contract #93

Merged
merged 5 commits into from
Nov 20, 2024
Merged

chore: Clean up contract #93

merged 5 commits into from
Nov 20, 2024

Conversation

clabby
Copy link
Member

@clabby clabby commented Nov 20, 2024

Overview

Small changes to RISCV.sol for ethereum-optimism/optimism#12994. Mainly syntax changes to pass semgrep and some doc comments.

@clabby clabby force-pushed the cl/contract-updates branch 2 times, most recently from 2a600e6 to 4e0fcf4 Compare November 20, 2024 00:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 61.89%. Comparing base (df0d2cc) to head (9246665).

Files with missing lines Patch % Lines
rvgo/bindings/riscv.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   62.10%   61.89%   -0.22%     
==========================================
  Files          27       27              
  Lines        4077     4091      +14     
==========================================
  Hits         2532     2532              
- Misses       1413     1427      +14     
  Partials      132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@clabby clabby force-pushed the cl/contract-updates branch from 4e0fcf4 to 9d9ad00 Compare November 20, 2024 02:56
@mininny mininny requested review from mininny and ImTei November 20, 2024 07:07
@clabby clabby added this pull request to the merge queue Nov 20, 2024
Merged via the queue into master with commit 54e90a2 Nov 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants