Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for F_GETFD in order to support go1.22+ #84

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

mininny
Copy link
Collaborator

@mininny mininny commented Oct 6, 2024

Description
Optimism has recently updated its go version to go1.22.
However, updating to go1.22 introduces an error in the vm: cannot open standard fds. This is because go added checks for standard file descriptors: golang/go@d4dd1de.

This can be fixed by adding support for handling F_GETFD in the vm.

A corresponding PR for cannon is in ethereum-optimism/optimism#12050

Tests

  • All existing test suites passes
  • New fuzz tests for testing the correct behavior of F_GETFD

@mininny mininny force-pushed the feature/mininny/support-getfd branch from f329bdf to 09810ae Compare October 6, 2024 22:28
@mininny mininny force-pushed the feature/mininny/support-getfd branch from 09810ae to 314efff Compare October 6, 2024 22:46
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.13%. Comparing base (25feabf) to head (052e14c).

Files with missing lines Patch % Lines
rvgo/fast/vm.go 42.10% 11 Missing ⚠️
rvgo/slow/vm.go 42.10% 11 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (25feabf) and HEAD (052e14c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (25feabf) HEAD (052e14c)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   72.01%   63.13%   -8.89%     
==========================================
  Files          16       26      +10     
  Lines        2734     3144     +410     
==========================================
+ Hits         1969     1985      +16     
- Misses        681     1075     +394     
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mininny mininny marked this pull request as ready for review October 7, 2024 16:02
@mininny mininny force-pushed the feature/mininny/support-getfd branch from 052e14c to 314efff Compare October 8, 2024 15:21
@mininny
Copy link
Collaborator Author

mininny commented Oct 8, 2024

I will update go version to go1.22 in CI / go.mod in this PR because of other code needs changes as well

@mininny mininny requested review from pcw109550 and ImTei October 8, 2024 15:22
Copy link
Collaborator

@ImTei ImTei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mininny mininny added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit 019d4b9 Oct 8, 2024
15 checks passed
@mininny mininny mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants