fix: PreimageOracle off-by-one #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83cb772 to
6a384a8
Compare
f5200e1 to
ad94f2d
Compare
e7da1f6 to
6b0f2ee
Compare
6b0f2ee to
0b86f77
Compare
This was referenced Feb 8, 2024
Merged
ImTei
approved these changes
Feb 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mirrors ethereum-optimism/optimism#9035 which corrects off by one error in preimage oracle contract.
Tests
Adds single test which is also mirrored.
Additional context
Current dependencies on/for this PR:
Step.sol#12