Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert reserved immediate word shifts with imm[5]!=0 #105

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

mininny
Copy link
Collaborator

@mininny mininny commented Dec 15, 2024

Description

As per specification: "SLLIW, SRLIW, and SRAIW encodings with imm[5] != 0 are reserved".

However, implementations (sol/fast/slow) accept it.

This PR reverts the reserved SLLIW/SRLIW/SRAIW instructions with imm[5] != 0

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.64%. Comparing base (45c520d) to head (f4452bd).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
rvgo/fast/vm.go 25.00% 4 Missing and 2 partials ⚠️
rvgo/slow/vm.go 25.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   61.78%   61.64%   -0.15%     
==========================================
  Files          27       27              
  Lines        4132     4148      +16     
==========================================
+ Hits         2553     2557       +4     
- Misses       1436     1444       +8     
- Partials      143      147       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mininny mininny force-pushed the feature/mininny/audit-6 branch from f25e041 to 81622bb Compare December 15, 2024 08:37
@mininny mininny force-pushed the feature/mininny/audit-6 branch from 895138a to da9d3e2 Compare December 16, 2024 02:03
@BlocksOnAChain BlocksOnAChain added the Audit finding grouping for our audit findings label Dec 16, 2024
@mininny mininny requested review from refcell January 9, 2025 02:10
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mininny mininny force-pushed the feature/mininny/audit-6 branch from 91e47af to f4452bd Compare January 15, 2025 21:13
@mininny mininny added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit 3f1f5fc Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audit finding grouping for our audit findings
Development

Successfully merging this pull request may close these issues.

4 participants