Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon validation for file size and duplicates #6076

Closed

Conversation

Ramyromel
Copy link

@Ramyromel Ramyromel commented Oct 26, 2024

Add validation for icon file size and duplicate icons.

  • README.md

    • Add information about icon file size validation.
    • Add information about duplicate icon validation.
  • .github/workflows/pr_checks.yml

    • Add validation for icon file size in the validate_icons job.
    • Add validation for duplicate icons in the validate_icons job.
  • maintainer_checklist.md

    • Add a step to check for duplicate icons.
    • Add a step to check for icon file size.
  • processor/src/main/kotlin/org/ethereum/lists/chains/Main.kt

    • Add logic to check for duplicate icons by calculating a hash (e.g., SHA-256) of each icon file.
    • Add logic to validate icon file size.

For more details, open the Copilot Workspace session.

@ethereum-lists ethereum-lists deleted a comment from github-actions bot Oct 26, 2024
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - great contribution!
But the CI must pass and currently it fails on historic icons - so either an exception to them or they need to be converted to fit the new (and useful) constraints

@ligi
Copy link
Member

ligi commented Nov 28, 2024

would really love to get this merged - but not sure how to deal with the failing legacy
Maybe in step #1 just allow-list them so they do not fail so there is no new stuff coming in violating these constraints.
But then we also need to phase out old data ..

ideas welcome!

@ligi
Copy link
Member

ligi commented Dec 10, 2024

also looked into this a bit deeper - the "duplicate" thing is a bit weird to me - they should then also have the same IPFS CID right? Same content -> same CID

@ligi ligi mentioned this pull request Dec 11, 2024
@ligi
Copy link
Member

ligi commented Dec 11, 2024

made a follow up PR here: #6386

@Ramyromel Ramyromel closed this Jan 16, 2025
@Ramyromel Ramyromel force-pushed the add-icon-validation branch from 79f3e22 to a52203d Compare January 16, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants