Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Avalanche Subnets #1388

Closed
wants to merge 16 commits into from
Closed

Add Avalanche Subnets #1388

wants to merge 16 commits into from

Conversation

connorch
Copy link
Contributor

Hi there 👋! I'm a dev with the Ava Labs team. This PR adds a few Avalanche Subnet chains, and also updates some existing ones with proper branding and explorer/rpc URLs.

ligi
ligi requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are subnets please consider using the parent field

@ligi
Copy link
Member

ligi commented Jul 25, 2022

also please resolve the conflict

@connorch
Copy link
Contributor Author

@ligi - The merge conflicts are now resolved!

How would you recommend we use the parent field for subnets? It seems that the parent field is used to declare a parent "chain" for L2s and shards, but this doesn't exactly align with subnet architecture since subnets don't have a parent chain. Subnets do have a parent validator network though (i.e. Blockchains on subnets are validated by a subset of validators on the Avalanche Primary Network).

If we had to pick a specific blockchain to list as each subnets' parent, it would have to be the P-Chain, however the P-Chain isn't an EVM so adding that chain to this repo probably wouldn't make sense.

I would appreciate your guidance with this, and I'd be happy to discuss subnet architecture a bit more with you if it will help come to a resolution. Thanks!

@connorch connorch requested a review from ligi July 28, 2022 01:38
@connorch
Copy link
Contributor Author

@ligi Please let me know if there's anything else I can do here. I don't think the parent field will apply to subnets, as each subnet is an independent L1.

@k-822
Copy link

k-822 commented Aug 3, 2022

@ligi We're at the AvaLabs team and trying to merge this to enable some features on our new explorer here. Could you please review and merge. Happy to discuss if you have any questions.

@connorch
Copy link
Contributor Author

connorch commented Aug 9, 2022

@ligi sorry for the ping again, but as @k-822 mentioned, this PR is blocking some features from functioning in our explorer. Is there something that can be done to help move this along? Thank you!

Also, again regarding your comment on the parent field, given that these subnets are standalone blockchains and not shards or L2s, it doesn't seem that adding the parent field makes sense here.

@connorch
Copy link
Contributor Author

@ligi Bumping this - if you have a chance to review again sometime soon it would be very much appreciated 🙏 . This is blocking us on some important new features in our new subnet explorer since our external contract verification service (Sourcify) requires that the chain is added here.

@zaksta11
Copy link

zaksta11 commented Aug 19, 2022 via email

@connorch
Copy link
Contributor Author

connorch commented Aug 30, 2022 •
edited
Loading

@ligi Is there anything at all I can do to help push this along? Or is there someone else that can help us if you're unavailable? We've been struggling to catch your eye (we even tried tweating you) but it really is important to us that we get this pushed through and this PR has been open for over a month.

We're borderline considering building out our entire own contract verification service because ethereum-lists is a Sourcify dependency and it's been such a challenge to get this PR pushed through.

@zaksta11
Copy link

zaksta11 commented Aug 30, 2022 via email

@connorch
Copy link
Contributor Author

How can I help..I need a job

Appreciate your offer to help @zaksta11 , but all we need here is a review from one of the repo owners, such as @ligi

@connorch
Copy link
Contributor Author

Closing this since we're not making progress here. Going to resubmit this PR with smaller changes.

@connorch connorch closed this Sep 19, 2022
@APrimaveraV
Copy link

APrimaveraV commented Oct 11, 2022 via email

@zaksta11
Copy link

zaksta11 commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi Awaiting requested review from ligi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@connorch @ligi @k-822 @zaksta11 @APrimaveraV