runtime: require and deprecate node 6.9.0 #3431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Etherpad 1.6.6 does not run on node <= 5 already. Node 6.9 is the first LTS release in the 6 series, and comes with npm 3.10.8. Declarations in package.json are advisory unless the user has set `engine-strict` config flag. Updated the docs accordingly.
|
Github closes my PR when I force push the branch it refers to. Super weird. isaacs/github#361 (comment) did not save me, because the first commit was squashed. Super super weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP for implementing the deprecation support discussed in #3424 (comment).