Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Etherpad 1.8rc0 does not start: Maximum call stack size exceeded in graceful-fs #3654

Closed
muxator opened this issue Oct 22, 2019 · 0 comments
Closed

Etherpad 1.8rc0 does not start: Maximum call stack size exceeded in graceful-fs #3654

muxator opened this issue Oct 22, 2019 · 0 comments
Assignees
@muxator

Comments

@muxator
Copy link
Contributor

muxator commented Oct 22, 2019

Etherpad d967914 (the rc0 for Etherpad 1.8) does not start with the following error:

[2019-10-22 19:01:01.439] [ERROR] console - exception thrown: Maximum call stack size exceeded
[2019-10-22 19:01:01.439] [INFO] console - RangeError: Maximum call stack size exceeded
    at Function.[Symbol.hasInstance] (<anonymous>)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:194:14)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:195:28)
    at ReadStream (/opt/etherpad-lite/src/node_modules/graceful-fs/graceful-fs.js:195:28)

This can be replicated running the default Docker image for 55fb10c (the corresponding version on the develop branch) from https://hub.docker.com/r/etherpad/etherpad/builds.

From inside the Docker image:

# node --version
v12.13.0     # the same happens on 10.x

# npm --version
6.12.0

The error seems to be in graceful-fs, and goes away updating to the latest version (https://www.npmjs.com/package/graceful-fs/v/4.2.2).
@muxator muxator self-assigned this Oct 22, 2019
@ghost ghost mentioned this issue Oct 31, 2019
Closed
muxator added a commit that referenced this issue Nov 2, 2019
@muxator
Release version 1.8.0-beta.1
503b117 
The previous revision on master (d967914), that claimed to be 1.8.0, had a
problem (see #3654), and so 1.8.0 was put on hold.

In #3660 I decided to do a beta.1 release, in order to be able to catch similar
problems.

Closes #3658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muxator muxator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@muxator