Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset scroll offset on item change #37

Closed
eth0net opened this issue Aug 4, 2022 · 0 comments · Fixed by #38
Closed

Reset scroll offset on item change #37

eth0net opened this issue Aug 4, 2022 · 0 comments · Fixed by #38
Assignees
Labels
bug Something isn't working

Comments

@eth0net
Copy link
Owner

eth0net commented Aug 4, 2022

Scroll offset needs resetting when the item is changed, or at least capped to the max offset.

If you scroll down a long list, then change the item to something with a shorter list, you can end up with an empty list as the offset is now higher than the list length.

Resetting the scrollOffset to 0 may be the best default, as it's an easy to understand behaviour, though this could be made configurable in the future.

@eth0net eth0net self-assigned this Aug 4, 2022
@eth0net eth0net added the bug Something isn't working label Aug 4, 2022
eth0net added a commit that referenced this issue Aug 4, 2022
@eth0net eth0net moved this from ✏ Planned to 🚀 Released in Enchant Menu Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚀 Released
Development

Successfully merging a pull request may close this issue.

1 participant